[PATCH] D67322: [LLD][ThinLTO] Handle GUID collision in import global processing

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In D67322#1707478 <https://reviews.llvm.org/D67322#1707478>, @the_jk wrote:

> Another place that already handles multiple locals with the same GUID is in the same file: bool FunctionImportGlobalProcessing::shouldPromoteLocalToGlobal(), from a comment there:
>
>   // When exporting, consult the index. We can have more than one local
>   // with the same GUID, in the case of same-named locals in different but
>   // same-named source files that were compiled in their respective directories
>   // (so the source file name and resulting GUID is the same). Find the one
>   // in this module.
>   
>
> so I think raising an error would cause surprises for different setups. 
>  I'll gladly add more testcases if you can give me some ideas/tips on possible problems.


I think the testing you have here is good for this patch. But please implement my suggestion to use findSummaryInModule, and also add a comment similar to this one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67322/new/

https://reviews.llvm.org/D67322