[PATCH] D69370: [LICM] Invalidate SCEV upon instruction hoisting

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 24 12:24:33 PDT 2019


asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

Thank you for the patch! This LGTM as is.

AFAICT, this issue should not occur in sinking, because instructions are not moved there, they are cloned and ScEv will simply not know about the new instructions.

There are a few deletes that may need updating in a follow up, as I'm not sure if the `forgetLoop` call addresses these.

- In `eraseInstruction`.
- In LoopPromoter.
- Potential updates in ControlFlowHoister.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69370/new/

https://reviews.llvm.org/D69370





More information about the llvm-commits mailing list