[PATCH] D69313: Handle more crt*.o filename variants.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Could you add a test?



================
Comment at: lld/ELF/OutputSections.cpp:396
+  s = llvm::sys::path::filename(s);
+  static std::regex re(R"((clang_rt\.)?crtbegin[ST]?(\-.*)?\.o)");
+  return std::regex_match(s.data(), re);
----------------
nit: You don't need to escape `-` as it is not a metacharacter


================
Comment at: lld/ELF/OutputSections.cpp:402
+  s = llvm::sys::path::filename(s);
+  static std::regex re(R"((clang_rt\.)?crtend[ST]?(\-.*)?\.o)");
+  return std::regex_match(s.data(), re);
----------------
ditto


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69313/new/

https://reviews.llvm.org/D69313