[PATCH] D69372: [X86][VARARG] Avoid spilling xmm vararg arguments.

[Alexey Lapshin via Phabricator via llvm-commits]

avl marked 2 inline comments as done.
avl added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:3502
+      } else {
+        // TODO: add check for possibility to not store guarded vararg
+        // TODO: parameters. If function contains only musttail calls, if it
----------------
asl wrote:
> What is the status of all these TODO here and there?
I assume  they would be done later. They are not required for correctness.

1. not storing xmm registers if "no fp, only musttail calls, noimplcitfloat". I am going to do after this patch and D62639 would be integrated.
2.  support of YMM and ZMM would be done by someone who would implement support of YMM and ZMM registers for varargs. this is separate task.
3. comment for AArch64 - for someone who would implement that on AArch64.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:80
+    /// X86 compare and logical compare instructions.
+    CMP,
+    COMI,
----------------
asl wrote:
> Do you really need these changes?
no, I don`t . it was done by clang-format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69372/new/

https://reviews.llvm.org/D69372