[PATCH] D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI.

Thu Oct 24 09:23:08 PDT 2019

jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.

LGTM.

================
Comment at: llvm/test/CodeGen/PowerPC/aix-byval-param.ll:1
+; RUN: not llc -mtriple powerpc-ibm-aix-xcoff < %s 2>&1 | FileCheck %s
+; RUN: not llc -mtriple powerpc64-ibm-aix-xcoff < %s 2>&1 | FileCheck %s
----------------
cebowleratibm wrote:
> ZarkoCA wrote:
> > jasonliu wrote:
> > > add -verify-machine-instr, -mcpu to all the llc command?
> > For the calling conventions we've been using -stop-after=machine-cp, so no need for -verify-machine-instr etc at this point. 
> > 
> > That said, I guess these testcase are here for to generate the error but it would be useful if the RUN command was reflected what we usually do, that way we make sure the tests are uniform if/when we enable these. 
> I'm not adding -verify-machine-instr because of -stop-after=machine-cp
> 
> These CC tests are not sensitive to cpu level because the ABI must be consistent across all AIX supported cpu.  One thought is to explicitly run the CC tests in all -mcpu, however, I think that's overkill.
I see. Missed the fact it is testing MIR. Thanks. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69101/new/

https://reviews.llvm.org/D69101