[PATCH] D69361: [IRMover] Set Address Space for moved global values

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

This seems fine to me, but can you pull out and commit the NFC parts first, and update the patch to just contain the functional change? It's harder to see with all the NFC changes in here. The NFC part can go in without a phabricator patch.



================
Comment at: llvm/test/Linker/addrspace.ll:1
+; RUN: llvm-link %s -S | FileCheck %s
+
----------------
suggest adding an alias in here for completeness


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69361/new/

https://reviews.llvm.org/D69361