[PATCH] D69339: [SelectionDAG] Add support for FP_ROUND in WidenVectorOperand.

Wed Oct 23 18:00:44 PDT 2019

craig.topper added a comment.

I think the code looks fine, but it doesn't look like some of the code is tested. And may not be testable?

================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:4301
     SDValue Res;
     if (N->isStrictFPOpcode()) {
+      if (Opcode == ISD::STRICT_FP_ROUND)
----------------
I'm not sure how this if could be true given that the opposite was checked in outer if. But since that was already like that when you got here this looks fine.

================
Comment at: llvm/test/CodeGen/AMDGPU/fptrunc.ll:34
+; FUNC-LABEL: {{^}}fptrunc_v3f64_to_v3f32:
+; GCN: v_cvt_f32_f64_e32
+; GCN: v_cvt_f32_f64_e32
----------------
Is this hitting the unrolling path rather than any of the code that creates a wider node?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69339/new/

https://reviews.llvm.org/D69339