[PATCH] D67556: [ARM][AArch64][DebugInfo] Improve call site instruction interpretation

Wed Oct 23 12:14:18 PDT 2019

aprantl added inline comments.

================
Comment at: include/llvm/CodeGen/TargetInstrInfo.h:947
+  /// If the specific machine instruction is an instruction that adds an
+  /// immediate value to its @Source operand and stores it in @Destination,
+  /// return true along with @Destination and @Source machine operand to which
----------------
dstenb wrote:
> NikolaPrica wrote:
> > aprantl wrote:
> > > nit: `\c Source`
> > Sorry, I'm not sure what are you aiming at. Do you think I should replace the order of Source and Destination?
> Looking at the Doxygen documentation, it appears that `@` is an alias for `\`, i.e. a command prefix, so I think this says that `Source` and `Destination` are Doxygen commands. `\c Source` would print the variable with the typewriter font, which I guess was the intention here?
Correct. We generally prefer the `\` version over `@` in LLVM.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67556/new/

https://reviews.llvm.org/D67556