[PATCH] D69027: [llvm-dwarfdump][Statistics] Fix calculation of OffsetToFirstDefinition

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: tools/llvm-dwarfdump/Statistics.cpp:149
 
+static uint64_t adjustScopeToFirstDef(uint64_t BytesInScope, uint64_t FirstDef,
+                                      const DWARFDie &ScopeDie,
----------------
Can you add a /// comment that explains what this function is doing?


================
Comment at: tools/llvm-dwarfdump/Statistics.cpp:532
   /// version.
   unsigned Version = 3;
   unsigned VarParamTotal = 0;
----------------
Since this is going to change the results in an incomparable way, can you please also bump the version number?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69027/new/

https://reviews.llvm.org/D69027