[PATCH] D69069: [IPO] Convert LoopExtractor pass from LoopPass to ModulePass

[Ehud Katz via Phabricator via llvm-commits]

ekatz marked an inline comment as done.
ekatz added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/LoopExtractor.cpp:61
       AU.addRequired<DominatorTreeWrapperPass>();
       AU.addRequired<LoopInfoWrapperPass>();
       AU.addUsedIfAvailable<AssumptionCacheTracker>();
----------------
asbirlea wrote:
> Does this preserve LoopInfo? If yes, `addPreserved`, if unsure best to leave as is.
> 
> Similar question on the DomTree.
> This is an item where I don't honestly understand if there are potential correctness implications in `extractLoops` if the DT is not preserved while iterating.
You are correct. I will add the preservation of LoopInfo, as it is.
The DomTree is not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69069/new/

https://reviews.llvm.org/D69069