[PATCH] D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI.

Wed Oct 23 11:27:42 PDT 2019

jasonliu added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6821
   // Adjust the stack pointer for the new arguments...
-  // These operations are automatically eliminated by the prolog/epilog
-  // inserter pass.
+  // These operations are automatically eliminated by the prolog/epilog pass
   Chain = DAG.getCALLSEQ_START(Chain, NumBytes, 0, dl);
----------------
nit: Add '.' for the sentence.

================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6727
+  // Arguments always reserve parameter save area.
+  switch (LocVT.SimpleTy) {
+  default:
----------------
Nit: I know in the caller side of CC functions, we always pass in the same argument for both LocVT and ValVT. But to  be more pedantic and for both paramaters intended usage, should we check the ValVT here instead?

================
Comment at: llvm/test/CodeGen/PowerPC/aix-byval-param.ll:1
+; RUN: not llc -mtriple powerpc-ibm-aix-xcoff < %s 2>&1 | FileCheck %s
+; RUN: not llc -mtriple powerpc64-ibm-aix-xcoff < %s 2>&1 | FileCheck %s
----------------
add -verify-machine-instr, -mcpu to all the llc command?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69101/new/

https://reviews.llvm.org/D69101