[PATCH] D68209: [LiveDebugValues] Introduce entry values of unmodified params
Djordje Todorovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 23 04:13:52 PDT 2019
djtodoro marked an inline comment as done.
djtodoro added inline comments.
================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:418
+ };
+ using DebugParamMap = SmallDenseMap<const DILocalVariable *, EntryValue>;
+
----------------
jmorse wrote:
> Can there be fragments of entry values? Typically a <DILocalVariable, InlinedAt, Fragment> tuple is needed to uniquely identify a variable location. I understand inlining doesn't make sense in the context of entry values, but if there can be fragments, then the map key here may need to account for them, now or in the future.
At the moment, we do not support fragments, so only the `DILocalVariable` is enough for now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68209/new/
https://reviews.llvm.org/D68209
More information about the llvm-commits
mailing list