[PATCH] D69304: [llvm-objcopy] - Do not crash on object that has relocations but no symbol table.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D69304#1718059 <https://reviews.llvm.org/D69304#1718059>, @MaskRay wrote:

> An alternative approach is to generalize `else if (EnsureSymtab)` for non --add-symbol= operations as well.


I am not sure I understood the idea honestly. Here we have an object that has a relocation which references a symbol when symbol table is not exist.
In my understanding it is not a situation where we might want to create a symbol table, it is probably about we should report an error?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69304/new/

https://reviews.llvm.org/D69304