[PATCH] D69313: Handle more crt*.o filename variants.

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 13:17:17 PDT 2019


saugustine marked an inline comment as done.
saugustine added inline comments.


================
Comment at: lld/ELF/OutputSections.cpp:390-391
+//
+// Gcc uses any of crt[begin|end][<empty>|S|T].o.
+// Clang uses Gcc's plus clang_rt.crt[begin|end][<empty>|S|T][-<arch>|<empty>].o.
 static bool isCrtBeginEnd(StringRef s, StringRef filename) {
----------------
ruiu wrote:
> At this point maybe we should consider start using regexps?
Entirely up to you. My preference is not strong.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69313/new/

https://reviews.llvm.org/D69313





More information about the llvm-commits mailing list