[PATCH] D69293: [Support] Add in memory flag for FileOutputBuffer

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 11:53:10 PDT 2019


ruiu added inline comments.


================
Comment at: llvm/include/llvm/Support/FileOutputBuffer.h:36-37
+
+    /// Always use an in-memory buffer instead of an on-disk buffer.
+    F_in_memory = 2,
   };
----------------
Technically mmap'ed files are also in memory (and on disk at the same time), so this comment might be a bit misleading. I'd name this F_no_mmap and explain that option as "Don't use mmap and instead write a in-memory buffer to a file when this buffer is closed".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69293/new/

https://reviews.llvm.org/D69293





More information about the llvm-commits mailing list