[PATCH] D69295: Optimize SHA1 implementation

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

This looks good, though I'm not an expert in this area.

If you really want to make this fast, I think Intel processors have special-purpose instructions to accelerate SHA1 computation. Have you consider using them?



================
Comment at: llvm/unittests/Support/raw_sha1_ostream_test.cpp:46
 
+TEST(sha1_hash_test, Update) {
+  SHA1 sha1;
----------------
Do we have a test that calls update() with a chunk of data larger than BLOCK_LENGTH?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69295/new/

https://reviews.llvm.org/D69295