[PATCH] D69288: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with concat_vectors

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 08:09:48 PDT 2019


qcolombet marked an inline comment as done.
qcolombet added inline comments.


================
Comment at: test/CodeGen/AArch64/GlobalISel/legalizer-combiner.mir:91
+    %2:_(<4 x s64>) = G_CONCAT_VECTORS %0(<2 x s64>), %1(<2 x s64>)
+    ADJCALLSTACKDOWN 0, 0, implicit-def $sp, implicit $sp
+    %3:_(s64), %4:_(s64), %5:_(s64), %6:_(s64) = G_UNMERGE_VALUES %2(<4 x s64>)
----------------
arsenm wrote:
> Is there a reason to have the ADJCALLSTACK?
No, there is not :).
The test physregs below were originally feeding a call.
I'll remove it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69288/new/

https://reviews.llvm.org/D69288





More information about the llvm-commits mailing list