[PATCH] D61917: [IR] allow fast-math-flags on select of FP values

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 06:01:35 PDT 2019


spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/trunk/lib/AsmParser/LLParser.cpp:5704
   // Other.
-  case lltok::kw_select:         return ParseSelect(Inst, PFS);
+  case lltok::kw_select: {
+    FastMathFlags FMF = EatFastMathFlagsIfPresent();
----------------
foad wrote:
> Why is the FMF handling done inline here, instead of in the body of ParseSelect ?
Copied from the similar block for fcmp just above here. No objection if you want to change it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61917/new/

https://reviews.llvm.org/D61917





More information about the llvm-commits mailing list