[PATCH] D69299: [yaml2obj] - Improve handling of the SHT_GROUP section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 04:02:42 PDT 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.

Currently, when we do not specify "Info" field in a YAML description
for SHT_GROUP section, yaml2obj reports an error:
"error: unknown symbol referenced: '' by YAML section '.group1'"

Also, we do not link it with a symbol table by default,
though it is what we do for AddrsigSection, HashSection, RelocationSection.
(http://www.sco.com/developers/gabi/latest/ch4.sheader.html#sh_link)

The patch fixes the missings mentioned.


https://reviews.llvm.org/D69299

Files:
  include/llvm/ObjectYAML/ELFYAML.h
  lib/ObjectYAML/ELFEmitter.cpp
  lib/ObjectYAML/ELFYAML.cpp
  test/tools/yaml2obj/duplicate-section-names.test
  test/tools/yaml2obj/elf-comdat-broken-info.yaml
  test/tools/yaml2obj/elf-comdat-broken-members.yaml
  test/tools/yaml2obj/elf-comdat-broken.yaml
  test/tools/yaml2obj/elf-override-shname.yaml
  test/tools/yaml2obj/elf-override-shoffset.yaml
  test/tools/yaml2obj/elf-override-shsize.yaml
  test/tools/yaml2obj/section-link.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69299.226016.patch
Type: text/x-patch
Size: 6242 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191022/ccac039b/attachment.bin>


More information about the llvm-commits mailing list