[PATCH] D69097: [AArch64][MachineOutliner] Return address signing for outlined functions

[David Tellenbach via Phabricator via llvm-commits]

tellenbach marked an inline comment as done.
tellenbach added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:5129
+  if (FCF.hasFnAttribute("sign-return-address")) {
+    NumBytesToCreateFrame += 8;
+  }
----------------
This is actually an assumption: If the candidates agree on `"sign-return-address"="non-leaf"`, the outlined function could potentially get signed. (and the outlined function could potentially increase by two instructions). However, it is not certainly true that it will be no leaf function (and hence needs no signing), This gets determined later when the decision to outline or not is already made.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69097/new/

https://reviews.llvm.org/D69097