[PATCH] D69278: [Alignment][NFC] Attributes use Align/MaybeAlign

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp:1574
       // Hopefully ptxas bug is fixed by then.
       if (!isKernelFunc && align < 4)
+        align = Align(4);
----------------
courbet wrote:
> `align < 4`: do we want this to compile ?
We need to be able to compare an alignment with an offset for instance, in which case there is no power of two guarantee.
In that sense, we want this to compile.

Now in this case I agree that it should be `align < Align(4)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69278/new/

https://reviews.llvm.org/D69278