[PATCH] D62908: [PowerPC] Improve float vector gather codegen
Nemanja Ivanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 21 17:20:43 PDT 2019
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM. +1 for pre-committing the test case.
================
Comment at: llvm/test/CodeGen/PowerPC/float-vector-gather.ll:12
+float* nocapture readonly %d) {
+; C code from which this IR test case was generate:
+; vector float test(float *a, float *b, float *c, float *d) {
----------------
amyk wrote:
> I think `C code from which this IR test case was generated from` would sound more clear.
I don't agree - let's not change it to end the sentence on a preposition :). But do add the missing letter and change `generate` to `generated`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62908/new/
https://reviews.llvm.org/D62908
More information about the llvm-commits
mailing list