[PATCH] D69136: Add an instruction marker field to the ExtraInfo in MachineInstrs.

Mon Oct 21 15:38:03 PDT 2019

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Nice, this looks good. :)

I think if we're going to do full due diligence for this system which we are starting to depend on, next we should serialize this data via MIR. In the MIParser we only handle MMOs, but we should handle these labels and heap alloc site markers here:
https://github.com/llvm/llvm-project/blob/18f805a/llvm/lib/CodeGen/MIRParser/MIParser.cpp#L953
That can be a separate change.

================
Comment at: llvm/test/CodeGen/X86/taildup-heapallocsite.ll:45
 ; CHECK: jmp f2 # TAILCALL

 declare dso_local i8* @alloc(i32)
----------------
Let's CHECK for two S_HEAPALLOCSITE records as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69136/new/

https://reviews.llvm.org/D69136