[PATCH] D68783: [AArch64][DebugInfo] Do not recompute CalleeSavedStackSize (Take 2)

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 21 12:03:51 PDT 2019


sdesmalen added a comment.

In D68783#1717082 <https://reviews.llvm.org/D68783#1717082>, @thakis wrote:

> In D68783#1717074 <https://reviews.llvm.org/D68783#1717074>, @sdesmalen wrote:
>
> > In D68783#1717046 <https://reviews.llvm.org/D68783#1717046>, @thakis wrote:
> >
> > > This breaks most bots on http://lab.llvm.org:8011/console . Unless this has a very quick fix, please revert and investigate asynchonously.
> >
> >
> > Are you sure these are caused by this patch though? (Most bots that fail test more than this patch and I also can't quickly see how it causes all these failures)
>
>
> Yes, http://45.33.8.238/linux/2376/summary.html for example has just your change.
>
> Maybe try reverting and if it doesn't help you know it's not your change. (It very likely is, though.)


Got it! Thanks, I didn't quickly spot that one test from the console output. I'll revert the test and fix this separately. Thanks for pointing out!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68783/new/

https://reviews.llvm.org/D68783





More information about the llvm-commits mailing list