[PATCH] D69231: AMDGPU/GlobalISel: Legalize fast unsafe FDIV

Mon Oct 21 10:36:51 PDT 2019

arsenm added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fast-unsafe-fdiv.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx900 -run-pass=legalizer -enable-unsafe-fp-math -global-isel-abort=0 -o - %s  | FileCheck -check-prefix=GFX9-UNSAFE %s
+
----------------
kerbowa wrote:
> arsenm wrote:
> > I don’t think this needs -global-isel-abort
> The legalization for base types will come in next series of patches. I could just remove it then.
Also need a runline for SI/CI to test the f16 promotion

================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fast-unsafe-fdiv.mir:244
+    $vgpr0_vgpr1 = COPY %2
+...
----------------
Missing vector tests for the scalarize action 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69231/new/

https://reviews.llvm.org/D69231