[PATCH] D69136: Add an instruction marker field to the ExtraInfo in MachineInstrs.

Amy Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 21 10:16:58 PDT 2019


akhuang updated this revision to Diff 225908.
akhuang marked 7 inline comments as done.
akhuang added a comment.

-Moved the logic for editing extra info for machine instrs into a separate function.
-Moved label creation code into CodeViewDebug.
-Remove now unused heapallocsite vector from MachineFunction.

I still need to write unit tests for the MachineInstr stuff. I've just been figuring
how to generate MCSymbols from the faked MachineFunction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69136/new/

https://reviews.llvm.org/D69136

Files:
  llvm/include/llvm/CodeGen/MachineFunction.h
  llvm/include/llvm/CodeGen/MachineInstr.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h
  llvm/lib/CodeGen/MachineFunction.cpp
  llvm/lib/CodeGen/MachineInstr.cpp
  llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
  llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp
  llvm/test/CodeGen/X86/label-heapallocsite.ll
  llvm/test/CodeGen/X86/taildup-heapallocsite.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69136.225908.patch
Type: text/x-patch
Size: 26940 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191021/8af7cc70/attachment.bin>


More information about the llvm-commits mailing list