[PATCH] D69255: [obj2yaml] - Better dumping for relocations without symbols associated.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 21 10:07:38 PDT 2019
MaskRay added a comment.
Herald added a subscriber: wuzish.
This is a reasonable change to eventually remove the implicit rule of .symtab definition.
================
Comment at: tools/obj2yaml/elf2yaml.cpp:416
+ // ABI) R_X86_64_NONE reloc.
const Elf_Sym *Sym = *SymOrErr;
+ if (!Sym)
----------------
R_X86_64_GOTPC32 and R_PPC64_TOC are examples that use 0 as the symbol index. We probably should not call them "edge cases".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69255/new/
https://reviews.llvm.org/D69255
More information about the llvm-commits
mailing list