[PATCH] D69256: [Alignment][NFC] Instructions::getLoadStoreAlignment
Guillaume Chatelet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 21 08:07:49 PDT 2019
gchatelet marked an inline comment as done.
gchatelet added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5829
+ Legal->isMaskRequired(I),
+ Alignment ? Alignment->value() : 0);
}
----------------
xbolva00 wrote:
> Maybe you can create new API:
> Alignment->valueOrZero()?
>
>
Thx for the notice @xbolva00. This code is just here for the transition and it will disappear once the `TTI.getXXXCost` functions take `MaybeAlign` instead of `unsigned`.
I'm reluctant to introduce a new API for the transition since it's a hole in the type system (typed -> untyped) having it part of the API would encourage its usage.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69256/new/
https://reviews.llvm.org/D69256
More information about the llvm-commits
mailing list