[PATCH] D69259: [NFC][PowerPC] Clean up PPCAsmPrinter with `IsPPC64` and `IsDarwin`

[Xiangling Liao via Phabricator via llvm-commits]

Xiangling_L marked 3 inline comments as done.
Xiangling_L added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:947
     const MCExpr *Exp = MCSymbolRefExpr::create(
-        MOSymbol,
-        Subtarget->isPPC64() ? MCSymbolRefExpr::VK_PPC_GOT_TPREL_LO
-                             : MCSymbolRefExpr::VK_PPC_GOT_TPREL,
+        MOSymbol, IsPPC64() ? MCSymbolRefExpr::VK_PPC_GOT_TPREL_LO
+                            : MCSymbolRefExpr::VK_PPC_GOT_TPREL,
----------------
hubert.reinterpretcast wrote:
> `IsPPC64` is used as a logical value just a few lines up, but is used as a function here.
Thank you for pointing this out, and I have updated this in my second commit. I guess it's a timing issue so you missed the second commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69259/new/

https://reviews.llvm.org/D69259