[PATCH] D69257: Outline non returning functions unless a longjmp

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya created this revision.
hiraditya added reviewers: tejohnson, fhahn.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
hiraditya added a comment.

Will add test case soon.


__assert_fail, abort, exit etc. are cold.
TODO: outline throw


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69257

Files:
  llvm/lib/Transforms/IPO/HotColdSplitting.cpp


Index: llvm/lib/Transforms/IPO/HotColdSplitting.cpp
===================================================================
--- llvm/lib/Transforms/IPO/HotColdSplitting.cpp
+++ llvm/lib/Transforms/IPO/HotColdSplitting.cpp
@@ -117,9 +117,8 @@
   if (blockEndsInUnreachable(BB)) {
     if (auto *CI =
             dyn_cast_or_null<CallInst>(BB.getTerminator()->getPrevNode()))
-      if (CI->hasFnAttr(Attribute::NoReturn))
-        return false;
-    return true;
+      return (CI->hasFnAttr(Attribute::NoReturn) &&
+          !CI->getName().startswith("longjmp"));
   }
 
   return false;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69257.225872.patch
Type: text/x-patch
Size: 586 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191021/58623c71/attachment.bin>