[PATCH] D29014: [SelDag] Implement FREEZE node

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune marked 6 inline comments as done.
aqjune added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:3105
   SDValue Op = getValue(I.getOperand(0));
+  if (I.getOperand(0)->getType()->isAggregateType()) {
+    /// Create a MERGE_VALUES node from the given operands.
----------------
craig.topper wrote:
> Would we better off just handling freeze on its own instead of adding all this aggregate code to the generic visitUnary?
I put it here as visitBinary() was also handling opcodes, but I have no special preference.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D29014/new/

https://reviews.llvm.org/D29014