[PATCH] D51794: AMDGPU: Don't error on calls to null or undef

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D51794#1233556 <https://reviews.llvm.org/D51794#1233556>, @rampitec wrote:

> In D51794#1233163 <https://reviews.llvm.org/D51794#1233163>, @arsenm wrote:
>
> > Considering emitting traps requires fixing traps first, otherwise a program that should work will incorrectly trap
>
>
> Do you agree that is how we have to handle it in principle? If that requres further fixes I do not object a todo comment here.


I think this purpose would be better served by some sort of sanitizer pass. These would typically be deleted, and it's an anomaly these would reach codegen to bother trapping on. Something else should have inserted a trap for useful debugging purposes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51794/new/

https://reviews.llvm.org/D51794