[PATCH] D66574: [lit] Make internal diff work in pipelines

[Joel E. Denny via Phabricator via llvm-commits]

jdenny updated this revision to Diff 225715.
jdenny edited the summary of this revision.
jdenny added a comment.

Rebased this onto D69207 <https://reviews.llvm.org/D69207>.

Changed `diff` so that, when printing differences to stdout in Windows, it always terminate lines with `\n` not `\r\n`.  That way, strict FileCheck directives checking the `diff` output succeed in both Linux and Windows.  This somehow wasn't an issue when `diff`
was internal to lit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66574/new/

https://reviews.llvm.org/D66574

Files:
  llvm/utils/lit/lit/TestRunner.py
  llvm/utils/lit/lit/builtin_commands/diff.py
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-unified-error-0.txt
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-unified-error-1.txt
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-unified.txt
  llvm/utils/lit/tests/max-failures.py
  llvm/utils/lit/tests/shtest-shell.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66574.225715.patch
Type: text/x-patch
Size: 27241 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191018/12ca7b75/attachment-0001.bin>