[PATCH] D69040: [TTI][LV] preferPredicateOverEpilogue

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 18 15:46:32 PDT 2019


hsaito added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7447
+  else if (PreferPredicateOverEpilog || Hints.getPredicate() ||
+           TTI->preferPredicateOverEpilogue(L, LI, *SE, *AC, TLI, DT))
     SEL = CM_ScalarEpilogueNotNeededUsePredicate;
----------------
@SjoerdMeijer thanks for the work. I like the direction you are heading to. Now that you are stepping into making this behavior default for some arch for some loop, please think about the hint needed to reverse that default choice, something along the lines of (TTI->prefer...(...) && Hints.getDoNotPredicate()) 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69040/new/

https://reviews.llvm.org/D69040





More information about the llvm-commits mailing list