[PATCH] D69196: Fix lld detection in standalone compiler-rt.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 18 15:27:55 PDT 2019


eugenis added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:500
   else()
-    set(COMPILER_RT_HAS_LLD FALSE)
+    set(COMPILER_RT_HAS_LLD COMPILER_RT_HAS_FUSE_LD_LLD_FLAG)
   endif()
----------------
pcc wrote:
> eugenis wrote:
> > I believe all the stuff above this line is necessary for non-standalone case, when the linker flag check would run before the linker itself is built.
> Shouldn't this be `${COMPILER_RT_HAS_FUSE_LD_LLD_FLAG}`?
It definitely should!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69196/new/

https://reviews.llvm.org/D69196





More information about the llvm-commits mailing list