[PATCH] D69161: [IR] Allow fast math flags on calls with floating point array type.

Fri Oct 18 09:34:28 PDT 2019

spatel added a comment.

In D69161#1714549 <https://reviews.llvm.org/D69161#1714549>, @foad wrote:

> In D69161#1714388 <https://reviews.llvm.org/D69161#1714388>, @spatel wrote:
>
> > I think this patch is also allowing the following constructs, but not testing for them.
>
>
> Are there any existing tests for fast math flags on select or phi, that I could extend? I didn't even know they were allowed because they weren't mentioned in this part of the docs (https://llvm.org/docs/LangRef.html#fast-math-flags) and they aren't explicitly listed in the implementation of FPMathOperator::classof.

Yes, select/phi are relatively recent additions, and we missed that LangRef update. Test diff ideas may be in these reviews:
D61917 <https://reviews.llvm.org/D61917>
D67564 <https://reviews.llvm.org/D67564>
D68748 <https://reviews.llvm.org/D68748>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69161/new/

https://reviews.llvm.org/D69161