[PATCH] D69013: [AArch64][X86] Don't assume __powidf2 is available on Windows.

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

I do like @rnk's suggestion for the emission of the error, but Im not really tied to it - if it triggers, the TLI for the target is not setup properly or is missing the symbol, in which case, it needs to be addressed anyways.  Beyond that, assuming that @rnk is okay with this, LGTM.  Thanks for fixing this.



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:581-582
+  if (!TLI.getLibcallName(LC)) {
+    // Some targets don't have a powi libcall; use pow instead.
+    report_fatal_error("Don't know how to soften fpowi to fpow");
+  }
----------------
rnk wrote:
> Can this be made into an assert or non-fatal error by DAG->getContext().emitError("..."), and then returning the input SDNode unmodified?
I would rather have this be a `report_fatal_error` or the `DAG->getContext().emitError` + `return SDNode()`.  Please don't make this into an assertion, I know too many people who tend to use the -Asserts variant of the toolchain.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69013/new/

https://reviews.llvm.org/D69013