[PATCH] D69161: [IR] Allow fast math flags on calls with floating point array type.

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D69161#1714388 <https://reviews.llvm.org/D69161#1714388>, @spatel wrote:

> I think this patch is also allowing the following constructs, but not testing for them.


Are there any existing tests for fast math flags on select or phi, that I could extend? I didn't even know they were allowed because they weren't mentioned in this part of the docs (https://llvm.org/docs/LangRef.html#fast-math-flags) and they aren't explicitly listed in the implementation of FPMathOperator::classof.

Incidentally, surely FPMathOperator::classof would be better implemented as a whitelist rather than a blacklist? At the moment I'm sure it is unintentionally allowing fast math flags on some instructions like ExtractValue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69161/new/

https://reviews.llvm.org/D69161