[PATCH] D68064: [Builtins] Provide a mechanism to selectively disable tests based on whether an implementation is provided by a builtin library.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

@joerg @rupprecht

So `lib/builtins/CMakeLists.txt` has

  set(GENERIC_SOURCES
    absvdi2.c
    ....
    divtc3.c
    ...
  )

and then later

  set(powerpc64_SOURCES
    ppc/divtc3.c
    ppc/fixtfdi.c
    ppc/fixunstfti.c
    ppc/fixunstfdi.c
    ppc/floattitf.c
    ppc/floatditf.c
    ppc/floatunditf.c
    ppc/gcc_qadd.c
    ppc/gcc_qdiv.c
    ppc/gcc_qmul.c
    ppc/gcc_qsub.c
    ppc/multc3.c
    ${GENERIC_SOURCES}
  )

so it looks like both `lib/builtins/divtc3.c` and `lib/builtins/ppc/divtc3.c` are used for the builtin library for powerpc. I'm guessing rather than using `set(powerpc64_SOURCES ... ${GENERIC_SOURCES})` we need a function that produces a list with files with duplicate filenames (not full path) removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68064/new/

https://reviews.llvm.org/D68064