[PATCH] D68064: [Builtins] Provide a mechanism to selectively disable tests based on whether an implementation is provided by a builtin library.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 13:04:13 PDT 2019


delcypher added subscribers: rupprecht, joerg.
delcypher added a comment.

Damn looks like something is broken for linux powerpc

http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/21208/steps/ninja%20check%201/logs/stdio

  llvm-lit: /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/projects/compiler-rt/test/builtins/Unit/lit.cfg.py:116: fatal: builtins_source_features contains duplicates: ['librt_has_divtc3']

I'm going to turn this into a warning to unbreak the bot for now.

@joerg @rupprecht Any idea what's going on here? My CMake code jsut reads the source files used to built the builtin library. My guess is that both `lib/builtins/ppc/divtc3.c` and  `lib/builtins/divtc3.c` are used to build the builtin library for powerpc. That sounds like a bug. I'd expect that to cause a linker error with  multiple symbols of the same name being defined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68064/new/

https://reviews.llvm.org/D68064





More information about the llvm-commits mailing list