[PATCH] D69028: [DebugInfo] Correctly place DW_OP_derefs for arguments passed on stack

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

This looks great.



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5564
+    } else {
+      Expr = DIExpression::prepend(Expr, DIExpression::DerefBefore);
+    }
----------------
Out of curiosity, why can't the sized deref be used for stack values?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69028/new/

https://reviews.llvm.org/D69028