[PATCH] D69142: [dsymutil] Add support for linking remarks

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg created this revision.
thegameg added reviewers: JDevlieghere, friss.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.
thegameg added a child revision: D69141: [Remarks] Add support for linking remarks.

This adds support to dsymutil for linking remark files and placing them in the final .dSYM bundle.

The result will be placed in:

- a.out.dSYM/Contents/Resources/Remarks/a.out

or

- a.out.dSYM/Contents/Resources/Remarks/a.out-<arch> for universal binaries

When multi-threaded, this runs a third thread which loops over all the object files and parses remarks as it finds __remarks sections.

Testing this involves running dsymutil on pre-built binaries and object files, then running llvm-bcanalyzer on the final result to check for remarks.


https://reviews.llvm.org/D69142

Files:
  llvm/test/tools/dsymutil/Inputs/basic1.c
  llvm/test/tools/dsymutil/Inputs/remarks/basic.macho.remarks.x86_64
  llvm/test/tools/dsymutil/Inputs/remarks/basic1.macho.remarks.x86_64.o
  llvm/test/tools/dsymutil/Inputs/remarks/basic1.macho.remarks.x86_64.opt.bitstream
  llvm/test/tools/dsymutil/Inputs/remarks/basic2.macho.remarks.x86_64.o
  llvm/test/tools/dsymutil/Inputs/remarks/basic2.macho.remarks.x86_64.opt.bitstream
  llvm/test/tools/dsymutil/Inputs/remarks/basic3.macho.remarks.x86_64.o
  llvm/test/tools/dsymutil/Inputs/remarks/basic3.macho.remarks.x86_64.opt.bitstream
  llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.i386.opt.bitstream
  llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86
  llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86.c
  llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86.o
  llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86.opt.bitstream
  llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86_64.opt.bitstream
  llvm/test/tools/dsymutil/Inputs/remarks/fat.macho.remarks.x86_64h.opt.bitstream
  llvm/test/tools/dsymutil/X86/basic-linking-bundle.test
  llvm/test/tools/dsymutil/X86/remarks-linking-bundle.test
  llvm/test/tools/dsymutil/X86/remarks-linking-fat-bundle.test
  llvm/tools/dsymutil/CMakeLists.txt
  llvm/tools/dsymutil/DwarfLinker.cpp
  llvm/tools/dsymutil/LinkUtils.h
  llvm/tools/dsymutil/Options.td
  llvm/tools/dsymutil/dsymutil.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69142.225515.patch
Type: text/x-patch
Size: 13098 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191017/9a6a9277/attachment.bin>