[PATCH] D69113: Expose __hwasan_tag_mismatch_stub

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan_interface_internal.h:115
 SANITIZER_INTERFACE_ATTRIBUTE
+void __hwasan_tag_mismatch_stub(uptr addr, uptr access_info,
+				uptr *registers_frame,
----------------
I think the _stub suffix does not make sense in a public interface function.
How about __hwasan_tag_mismatch4 - where 4 stands for the number of arguments?



================
Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:486
+  __hwasan::AccessInfo ai;
+  ai.is_store = access_info & 0x10;
+  ai.recover = access_info & 0x20;
----------------
There is a pre-existing bug here: this function needs to set the is_load member.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69113/new/

https://reviews.llvm.org/D69113