[PATCH] D68917: [Demangle] Add a few more options to the microsoft demangler

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked an inline comment as done.
mstorsjo added a comment.

In D68917#1713451 <https://reviews.llvm.org/D68917#1713451>, @thakis wrote:

> This is cool, thanks!
>
> Note that there are a 3 or so places where the demangler also hardcodes OF_Default. One patch that I have sitting around locally fixes one of them (https://gist.github.com/nico/8f219c64c9269c1f8c6657c46f3e8644 -- feel free to take that one over; I wrote it for something else that I couldn't yet prove is actually a problem; from the test script at the bottom you can probably figure out what it was :)). As-is, these options are ignored for these cases (cached types in templates, parent scopes of locally numbered scopes, and something else). It's possible that these contexts are unaffected by these options, but I figured I'd mention it, in case you want to check.


Oh, ok. TBH, unless there's a clear issue I'm running into, I don't think I'll be looking more into it right now. My original quest was to sift through lldb and enable as much as makes sense of `#ifdef _MSC_VER` blocks on mingw, and that's more or less comple now. :-) For the use of dbghelp for demangling I thought it'd be trivial to just convert to the internal demangler - instead of using more elaborate mechanisms than `#pragma comment(lib)` for linking to dbghelp. It turned out to be a bit bigger task than I had expected originally, but not too bad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68917/new/

https://reviews.llvm.org/D68917