[PATCH] D68133: [Symbolize] Use the local MSVC C++ demangler instead of relying on dbghelp. NFC.

Thu Oct 17 12:26:18 PDT 2019

mstorsjo added a comment.

In D68133#1713254 <https://reviews.llvm.org/D68133#1713254>, @rnk wrote:

> In D68133#1712212 <https://reviews.llvm.org/D68133#1712212>, @mstorsjo wrote:
>
> > It seems like this still broke a buildbot. @rnk, as it's your bot, can you look into it before we revert this? The logs don't really show enough detail... http://lab.llvm.org:8011/builders/sanitizer-windows/builds/53114/steps/stage%201%20check/logs/stdio
>
>
> Yep, done in r375147. The demangler difference is:
>
>   MS:   f(char,char *,char *)
>   LLVM: f(char, char *, char *)

Awesome, thanks! I guess that should have been deducible from the buildbot log, but I overlooked the spacing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68133/new/

https://reviews.llvm.org/D68133