[PATCH] D68916: [ARM] Accept ldrb.w mnemonic for certain addressing modes (PR43382)

[Momchil Velikov via Phabricator via llvm-commits]

chill marked an inline comment as done.
chill added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:1404
                       GPRnopc, zextloadi8>;
+def : t2InstAlias<"ldrb${p}.w $Rt, $addr", (t2LDRBi8 GPRnopc:$Rt, t2addrmode_negimm8:$addr,
+                                            pred:$p)>;
----------------
sdesmalen wrote:
> Does LDRH (and maybe other instructions) not suffer the same issue? If so, should these InstAliases be moved into `T2I_ld`?
Yes, other instructions have the same issue. I plan to fix (some of) them in separate patches, once the approach with `AsmMatchConverter` is validated as good enough. Then I'll look for opportunities to refactor.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68916/new/

https://reviews.llvm.org/D68916