[PATCH] D69112: [NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
David Tenty via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 17 10:33:26 PDT 2019
daltenty added inline comments.
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:113
+ // XCOFF have special section numbers for symbols:
+ // -2 Specifies N_DEBUG, a special symbolic debugging symbol.
----------------
nit: have -> has
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:260
+
+ llvm_unreachable("Program code should not reach here.");
+}
----------------
nit: this unreachable is unneeded because of the default case above
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69112/new/
https://reviews.llvm.org/D69112
More information about the llvm-commits
mailing list