[PATCH] D69110: [DFAPacketizer] Allow up to 64 functional units

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/utils/TableGen/DFAPacketizerEmitter.cpp:134
 int DFAPacketizerEmitter::collectAllComboFuncs(
-                            std::vector<Record*> &ComboFuncList,
-                            std::map<std::string, unsigned> &FUNameToBitsMap,
-                            std::map<unsigned, unsigned> &ComboBitToBitsMap,
-                            raw_ostream &OS) {
+    const std::vector<Record *> &ComboFuncList) {
   LLVM_DEBUG(dbgs() << "-------------------------------------------------------"
----------------
Maybe use ArrayRef here?


================
Comment at: llvm/utils/TableGen/DFAPacketizerEmitter.cpp:275
+                            NfaStateTy State) -> std::deque<uint64_t> {
+    std::deque<uint64_t> V(1, State);
     // Apply every stage in the class individually.
----------------
Should this be std::deque<NfaStateTy> ?


================
Comment at: llvm/utils/TableGen/DFAPacketizerEmitter.cpp:281
       for (unsigned I = 0; I < Sz; ++I) {
-        unsigned S = V.front();
+        uint64_t S = V.front();
         V.pop_front();
----------------
Ditto.


================
Comment at: llvm/utils/TableGen/DFAPacketizerEmitter.cpp:309
                               NfaStateTy State) -> bool {
-    for (unsigned Resources : InsnClass) {
+    for (uint64_t Resources : InsnClass) {
       if ((State | Resources) == State)
----------------
Should this be `NfaStateTy Resources : InsnClass` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69110/new/

https://reviews.llvm.org/D69110