[PATCH] D68438: [gicombiner] Add the run-time rule disable option

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: llvm/utils/TableGen/GICombinerEmitter.cpp:372
+     << "  if (!RangePair.second.empty()) {\n"
+     << "    const auto First = getRuleIdxForIdentifier(RangePair.first);\n"
+     << "    const auto Last = getRuleIdxForIdentifier(RangePair.second);\n"
----------------
sdmitriev wrote:
> getRuleIdxForIdentifier() is defined under #ifndef NDEBUG, but called without #ifndef NDEBUG. I assume this will cause an error if NDEBUG macro is defined.
Yes, you're right. The sanitizer-x86_64-linux-fuzzer bot complained at me about that and I fixed it in r375067

Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68438/new/

https://reviews.llvm.org/D68438