[PATCH] D69074: [lld][test] Fix use of escape character in an lld test on Windows
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 17 09:37:07 PDT 2019
rupprecht added a comment.
In D69074#1713028 <https://reviews.llvm.org/D69074#1713028>, @thakis wrote:
> Now also failing on a more reputable bot: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/28842/steps/test-check-all/logs/stdio
I don't fully understand the failure, but I've committed r375131. If it doesn't work, I'll revert both.
I have a suspicion that there's a bug in the filename matching (e.g. "foo/bar.txt" and "foo\bar.txt" should be equivalent in all places on windows), but I'm not enough of a linkerscript expert to do much about it. r375131 just tries to make it consistently "foo/bar.txt".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69074/new/
https://reviews.llvm.org/D69074
More information about the llvm-commits
mailing list